sadpandajoe commented on code in PR #45925: URL: https://github.com/apache/superset/pull/45925#discussion_r4432275320
########## AGENTS.md: ########## @@ -248,6 +248,7 @@ curl -f http://localhost:8088/health || echo "❌ Setup required - see https://s - Format: `type(scope): description` - Example: `fix(dashboard): load charts correctly` - Types: `fix`, `feat`, `docs`, `style`, `refactor`, `perf`, `test`, `chore` +4. **Follow guideline on AI-assisted PRs**: Understands expectations from reviewers for AI-assisted PRs in `docs/developer_docs/ai-pr-guideline.md`. Review Comment: This path points at `docs/developer_docs/ai-pr-guideline.md`, but the page is added under `docs/developer_docs/contributing/`, so anyone following this line can't open the guideline. Should this use the `contributing/` path? ########## docs/developer_docs/contributing/ai-pr-guideline.md: ########## @@ -0,0 +1,45 @@ +--- +title: Guideline on AI-assisted PR +sidebar_position: 3 Review Comment: The developer docs sidebar is an explicit list (`docs/sidebarTutorials.js`, Contributing category) and doesn't include `contributing/ai-pr-guideline`, so this page won't show in the nav and is reachable only through the new link in `submitting-pr.md`. Should it be added to that list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
