younsl commented on code in PR #489:
URL:
https://github.com/apache/superset-kubernetes-operator/pull/489#discussion_r4436266195
##########
.github/workflows/docs.yml:
##########
@@ -46,18 +80,27 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 #
v7.0.1
with:
persist-credentials: false
- - uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 #
v7.1.0
+ - name: Set docs ref, dry-run, and force
+ run: bash scripts/run-docs-ci.sh env >> "$GITHUB_ENV"
+ - uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 #
v7.0.0
with:
python-version: "3.15"
- name: Install dependencies
run: python -m pip install --require-hashes -r docs-requirements.txt
+ - name: Test documentation versioning and links
+ run: python scripts/test_docs_versions.py
+ - name: Prepare documentation source and links
+ run: bash scripts/run-docs-ci.sh prepare
+ - name: Build complete documentation tree
+ if: github.event_name != 'workflow_dispatch'
+ run: zensical build --clean --strict
- name: Build docs
- run: make docs-build
+ run: bash scripts/run-docs-ci.sh publish "$RUNNER_TEMP/docs-build"
deploy:
name: Deploy docs
needs: build
- if: github.event_name == 'push'
+ if: github.event_name != 'pull_request'
runs-on: ubuntu-latest
concurrency:
group: docs-deploy
Review Comment:
**Tag deploys can be silently dropped by the shared concurrency group**
`cancel-in-progress: false` only protects the running job. GitHub still
cancels any *pending* job in the same group when a newer one is queued. Before
this PR every deploy was a `main` push, so dropping a pending one was harmless
(the next push republishes everything). Now a release tag deploy is a one-shot
slice: if it is pending behind a running `main` deploy and another `main` push
lands (likely around a release, when version-bump docs commits and the tag go
out together), the tag deploy is cancelled and `X.Y/` plus the `latest` move
never get published, with no automatic retry.
Suggest keying the group per ref so tag deploys never replace or get
replaced by `main` deploys, and relying on the existing reset-and-rebuild retry
loop for concurrent `gh-pages` pushes:
```suggestion
concurrency:
group: docs-deploy-${{ github.ref }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
