alberttwong opened a new pull request, #45938:
URL: https://github.com/apache/superset/pull/45938

   ### SUMMARY
   
   A fresh source install can select an older published `apache-superset-core` 
with incompatible SQLAlchemy requirements, and the CLI imports `rich` even 
though package metadata does not declare it. Declare `rich` directly and 
document installing the application and core together from the same checkout, 
including the editable development command.
   
   Refs #45937 and #42568. This addresses the Superset packaging portion of 
#45937; it does not close the broader Flight SQL compatibility report. 
Table/type reflection fixes belong to the third-party adapter and are being 
submitted separately. The `rich` declaration also overlaps the broader, 
still-open Python 3.15 work in #45823; this PR offers the small independently 
validated packaging fix.
   
   No core version bound is invented before a matching package is published. 
The source-install command uses the matching local core without bypassing 
dependency resolution.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; dependency metadata and documentation only.
   
   ### TESTING INSTRUCTIONS
   
   Validated on Python 3.12.16, macOS arm64, against master 
`7519fa8b6f5a145097d51e36579240e872044266`:
   
   - Fresh virtual environment: `python -m pip install /path/to/superset 
/path/to/superset/superset-core` (plus pytest, pre-commit and build as 
validation tools). `rich==15.0.0` was installed through application metadata, 
without an explicit rich install.
   - `python -m pip check`: no broken requirements.
   - Installed package metadata declares rich; `superset --help` succeeds with 
disposable local configuration.
   - `superset db upgrade` against a fresh isolated SQLite metadata database 
succeeds.
   - Application creation and `/health`: HTTP 200.
   - `pre-commit run` on all three staged files: all applicable checks passed.
   - `git diff --check`: passed.
   
   Reproduce with a clean Python 3.12 environment, the documented 
source-install command, and a disposable Superset configuration. No existing 
metadata or running deployment needs changing.
   
   Separately, the adapter fix was exercised with Superset 7.0.0rc2 against a 
disposable Redis Arrow Flight SQL endpoint: table discovery, 
BIGINT/VARCHAR/FLOAT column reflection, ordered/NULL/empty reads, SQL Lab 
CREATE/INSERT/UPDATE/DELETE/DROP with read-back assertions, dataset creation, 
and a grouped chart data query passed. Browser rendering and production 
behavior remain unverified.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #45937
   - [ ] Required feature flags
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] fix(pa... alberttwong (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... codecov[bot] (via GitHub) via notifications

Reply via email to