tien238lnd commented on issue #45174:
URL: https://github.com/apache/superset/issues/45174#issuecomment-6576037983

   Thanks @rusackas, not quite: #45176 only covers the case where 
`SEMANTIC_LAYERS` is off, because it routes the list through `/api/v1/dataset/` 
only then. With the flag on, the page still calls `/api/v1/datasource/`, and 
that path still drops Editor, Modified by and Certified. @mikebridge made the 
same point on #45176 ("with them on, the combined filters still need fixing"). 
#45175 is the fix for that path, and it also makes the endpoint answer `400` 
for a filter it cannot apply, like `/api/v1/dataset/` does.
   
   If you would rather land only #45176 for now, that is fine with me, but the 
flag-on path would stay broken, so I would keep #45175 open as the fix for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to