jprinet commented on code in PR #45217:
URL: https://github.com/apache/superset/pull/45217#discussion_r4445530308
##########
superset-frontend/package.json:
##########
@@ -83,7 +83,7 @@
"storybook": "cross-env NODE_ENV=development BABEL_ENV=development
storybook dev -p 6006",
"test-storybook": "npx playwright test --config
.storybook/playwright.storybook-ci.config.ts",
"tdd": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\"
jest --watch",
- "test": "cross-env NODE_ENV=test
NODE_OPTIONS=\"--max-old-space-size=8192\" jest --silent",
+ "test": "cross-env NODE_ENV=test NODE_OPTIONS=\"$NODE_OPTIONS
--max-old-space-size=8192\" jest --silent",
Review Comment:
Yes. The CI containers get
`NODE_OPTIONS=--require=@gradle-tech/develocity-agent/preload` (see
`DEVELOCITY_DOCKER_ARGS`), which loads the agent. The `test` script used to
overwrite `NODE_OPTIONS`, dropping the preload, so jest runs produced no Build
Scan. Prefixing `$NODE_OPTIONS` keeps whatever's already set; when it's unset
(local runs, forks) it expands to nothing.
##########
superset-extensions-cli/.develocity.py:
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# The Develocity Python agent reads the configuration next to the nearest
pyproject.toml.
+# Keep in sync with ../.develocity.py.
Review Comment:
Yes. The agent finds the file with `is_file()` and loads it with
`open()`/`exec()`, both of which follow symlinks, so it's now a symlink to
`../.develocity.py` (5f7e1d83). One caveat: a Windows checkout with
`core.symlinks=false` gets a text file instead, and the agent then skips the
Build Scan without failing the build. Same as the existing `.nvmrc`/`.npmrc`
symlinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
