rebenitez1802 commented on code in PR #45860: URL: https://github.com/apache/superset/pull/45860#discussion_r4442931861
########## UPDATING.md: ########## @@ -24,6 +24,17 @@ assists people when migrating to a new version. ## Next +- Aborting or timing out an async chart-data query on Impala now cancels the + statement that is running. The cancel used to target the `USE <database>` + operation the driver runs when it opens a cursor, so the query ran to + completion, and without a database in the URL the task could not be aborted + at all. The cancel still goes through the coordinator's web UI + (`http://<host>:25000`), so the backend must reach that port, and a private or + internal coordinator needs `IMPALA_CANCEL_QUERY_ALLOW_INTERNAL_HOSTS = True`. + On every engine that supports cancellation, a chart-data task that is aborting + starts no further statements, such as a time comparison's offset query, and Review Comment: Good catch, thanks. Trino's cancel id only exists once the query is running, so on the chart path it never registers an abort handler and its tasks stay non-abortable, same as on master. I narrowed the note to engines whose cancel id is captured (Impala and the session-id engines) and called out Trino explicitly in d750338. Covering Trino would mean capturing the id during execute; I'd rather do that as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
