villebro commented on PR #44215: URL: https://github.com/apache/superset/pull/44215#issuecomment-6583808285
Rebased onto current master and addressed the open review point. @madhushreeag, thanks for the attach-path finding: it was valid. It's closed by #45538, now on master and included here after the rebase. `DashboardDAO.set_dash_metadata` refuses a layout that adds a chart the caller can't read (422), covering dashboard update, create and copy. Charts already on the dashboard stay accepted. A crafted `json_metadata.positions` can no longer attach an unreadable chart, so the editor inheritance can't be used to reach that chart's dataset. `VIEWER_PROMISCUOUS_MODE` remains a deliberate, opt-in relaxation. A dashboard's editors and viewers can read the data behind its charts without dataset grants, so data another editor placed on the dashboard is reachable by design. be38800edc documents that in SECURITY.md (out of scope, with what stays in scope: reaching charts or datasets not on an accessible dashboard, attaching unreadable charts, or extending it to embedded guests), in the `config.py` comment (which now also names editors), and in the admin security docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
