EnxDev commented on code in PR #45397: URL: https://github.com/apache/superset/pull/45397#discussion_r4448086094
########## superset-frontend/plugins/plugin-chart-echarts/src/Histogram/crossFilter.ts: ########## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + DataRecordValue, + getColumnLabel, + getTimeFormatter, + QueryFormColumn, + QueryObjectFilterClause, +} from '@superset-ui/core'; +import { GenericDataType } from '@apache-superset/core/common'; +import { formatSeriesName } from '../utils/series'; + +/** Matches `optionLabel` in `src/utils/common.ts`. */ +const EMPTY_STRING = '<empty string>'; Review Comment: `Bubble/crossFilter.ts` already exports `EMPTY_STRING` and `toJsonSafeFilterValue`, and its toKeyPart, `getSelectedBubbleKeys `and `dimensionFilter `are the same code as `toKeyPart`, `getSelectedHistogramKeys `and the per-value branch of groupbyFilters here. Not a blocker, but since both files are yours, could the shared pieces move to a `src/utils/crossFilter.ts`, with `EMPTY_STRING` living in `src/constants.ts` next to NULL_STRING? Happy with that as a follow-up PR that touches both charts, if you'd rather keep this one focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
