codeant-ai-for-open-source[bot] commented on code in PR #45909:
URL: https://github.com/apache/superset/pull/45909#discussion_r4448348302
##########
.github/workflows/pre-commit.yml:
##########
@@ -174,8 +174,22 @@ jobs:
uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 #
v7.1.0
with:
node-version-file: "superset-frontend/.nvmrc"
- cache: "npm"
- cache-dependency-path: "superset-frontend/package-lock.json"
+
+ # Not setup-node's built-in `cache: npm`: it keys on the exact
+ # package-lock.json hash with no fallback, so every lockfile change
+ # makes npm ci re-download every tarball (including xlsx from
+ # cdn.sheetjs.com), exposing the install to any registry/CDN outage
+ # at that moment, which is how runs 40649064300 and 40679638770
+ # failed. Restoring from the prefix instead cuts the downloads to the
+ # changed packages.
+ - name: Cache npm
+ if: steps.changed_files.outputs.needs_node == 'true'
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `c1beb48`.
The npm cache and `npm ci` steps are both gated on `needs_frontend`, so
websocket-only runs that set only `needs_node` will not save an incomplete
cache.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
