codeant-ai-for-open-source[bot] commented on code in PR #45907:
URL: https://github.com/apache/superset/pull/45907#discussion_r4448684072
##########
superset/commands/semantic_layer/update.py:
##########
@@ -219,7 +219,19 @@ def run(self) -> Model:
self._properties["configuration"]
)
if "configuration" in self._properties:
- self._model.clear_metadata_cache()
+ try:
+ unchanged: bool = json.dumps(
+ json.loads(self._model.configuration or "{}"),
sort_keys=True
+ ) == json.dumps(
+ json.loads(self._properties["configuration"]),
sort_keys=True
+ )
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `25406ca`.
The comparison now parses the stored and incoming configurations directly.
If parsing fails, it sets `unchanged = False`, so the update proceeds instead
of treating malformed storage as `{}` and dropping the repair.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
