dylanpulver opened a new pull request, #45976: URL: https://github.com/apache/superset/pull/45976
### SUMMARY `tests/unit_tests/sql_lab_execution_context.py` holds six tests covering `SqlJsonExecutionContext` and `CreateTableAsSelect`, but the filename matches none of the `python_files` patterns in `pytest.ini`: ``` python_files = *_test.py test_*.py *_tests.py *viz/utils.py ``` Nothing imports the file either, so pytest never collects it and none of the tests run. This renames it to `test_sql_lab_execution_context.py`. The diff is a pure rename, with no change to the contents. The file was added in 5e060cef7 and edited twice since, most recently in 584466e02, so the tests have been kept up to date without ever running. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. ### TESTING INSTRUCTIONS Collection count over the unit test suite, before and after: ``` pytest tests/unit_tests/ --collect-only -q # 21844 tests collected # after the rename pytest tests/unit_tests/ --collect-only -q # 21852 tests collected ``` The difference of eight is exactly what the six functions produce, two of them being parametrized. Running them: ``` pytest tests/unit_tests/test_sql_lab_execution_context.py -q # 8 passed ``` Changing one expectation in `test_sql_json_execution_context_init` from `1` to `999` gives `1 failed, 7 passed`, so the tests assert rather than merely run. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
