Re: [PR] fix(models): close has_view connection and dispose evicted engines [superset]

[codeant-ai-for-open-source[bot] (via GitHub) via notifications]

codeant-ai-for-open-source[bot] commented on PR #45861:
URL: https://github.com/apache/superset/pull/45861#issuecomment-6613381014

   ## <a href="https://codeant.ai/"; title="CodeAnt AI"><img 
src="https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/codeant-block-purple-v2.svg";
 width="28" height="28" align="absmiddle" style="vertical-align:middle" 
alt="CodeAnt" /></a>&nbsp; CodeAnt PR Risk
   
   **🟡&nbsp; Medium Risk**
   
   - The PR needs attention before merging.
   - A concurrent cache miss may insert an engine with old settings after 
eviction, leaving an idle pooled connection that can block opening the edited 
configuration.
   
   **Assessed commit:** `82436aa7d75c`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org