aminghadersohi commented on PR #45845: URL: https://github.com/apache/superset/pull/45845#issuecomment-6615757694
@rebenitez1802 both inline follow-ups from your approval are addressed in 1cb704263a5b816912fa7b562f84b857ad140a38: - The fetch_data time-limit handler now sends only cancel_operation(reset_state=False) and abandons locally, with no CloseOperation or CloseSession from that path; handle_cursor keeps the full cleanup. CancelOperation itself is still not bounded, and the docstring and docs say so. Reply: https://github.com/apache/superset/pull/45845#discussion_r4449191425 - The Python unit-test workflow installs the hive and impala extras before pytest, so the transport test files no longer skip. requirements/development.in and requirements/development.txt are unchanged. Reply: https://github.com/apache/superset/pull/45845#discussion_r4449191663 The current head 7ea9cdbe1bddccd833982c5df5a84fef931cb4dd also invalidates abandoned pooled connections on checkin, from a later review thread: https://github.com/apache/superset/pull/45845#discussion_r4450484381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
