gabotorresruiz commented on code in PR #45996:
URL: https://github.com/apache/superset/pull/45996#discussion_r4469224718
##########
superset/databases/api.py:
##########
@@ -390,6 +398,57 @@ def get_connection(self, pk: int) -> Response:
except SupersetException as ex:
return self.response(ex.status, message=ex.message)
+ @expose("/<int:pk>/encrypted_extra_hints/", methods=("GET",))
+ @protect()
+ @safe
+ @statsd_metrics
+ @event_logger.log_this_with_context(
+ action=lambda self, *args, **kwargs: (
+ f"{self.__class__.__name__}.encrypted_extra_hints"
+ ),
+ log_to_statsd=False,
+ )
Review Comment:
Good catch, this is the default `log_this_with_context` behaviour. Switched
the endpoint to `include_request_data=False`, the same opt-out `oauth2` uses in
this file, so the audit row carries only the action, the user and `pk`;
`test_encrypted_extra_hints_ignores_query_params` now asserts that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
