sadpandajoe commented on code in PR #45935:
URL: https://github.com/apache/superset/pull/45935#discussion_r4461077628
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -269,7 +270,7 @@ const FilterBar: FC<FiltersBarProps> = ({
// Force instant updating for requiredFirst filters or auto-apply when
needed
const shouldDispatch =
dataMask.filterState?.value !== undefined &&
- ((isFirstTimeInitialization && filter.requiredFirst) ||
+ ((isFirstTimeInitialization && isRequiredFirst(filter)) ||
Review Comment:
All 101 existing tests still pass if this condition is changed back to the
truthy check, so the first-pick-before-Apply bug can return unnoticed. Can we
add a FilterBar regression with `requiredFirst: {}`, asserting applied state
stays unchanged until Apply, plus a `true` immediate-apply control?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
