sadpandajoe opened a new pull request, #45994: URL: https://github.com/apache/superset/pull/45994
### SUMMARY Follow-up to #45876, addressing review suggestions from @richardfogaca. - Adds an `UPDATING.md` note: deployments with a custom `MACHINE_AUTH_PROVIDER_CLASS` or `WEBDRIVER_AUTH_FUNC` that mint their own session with `login_user` must also call `stamp_login_time()` (from `superset.security.session_invalidation`) after a successful `login_user()`. Without it, reports and thumbnails for users with a session-invalidation epoch (e.g. after a password change or reset) fail with a 401. The note also records that PNG/PDF reports and thumbnails (via `authenticate_browser_context`, which uses the same `get_auth_cookies`) are covered by the core fix. - Drops the two hand-stamped tests (`stamped_after_epoch` / `stamped_before_epoch`) from `tests/unit_tests/utils/machine_auth_test.py`. They exercise `enforce_session_validity` directly, which `tests/unit_tests/security/test_session_invalidation.py` and `tests/integration_tests/security/session_invalidation_tests.py` already cover, so the file stays about machine auth. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF UI QA: not-required (docs and test-only change; no user-visible UI surface). ### TESTING INSTRUCTIONS ``` pytest tests/unit_tests/utils/machine_auth_test.py # 3 passed pytest tests/unit_tests/security/test_session_invalidation.py # 16 passed ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
