codeant-ai-for-open-source[bot] commented on code in PR #46037:
URL: https://github.com/apache/superset/pull/46037#discussion_r4480218817
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -586,18 +661,53 @@ const PropertiesModal = ({
// Section handlers for extracted components
const handleThemeChange = (value: any) => setSelectedThemeId(value || null);
+ const writeRefreshJson = (
+ { policy, refreshFrequency: frequency }: RefreshPolicyValues,
+ isPolicyToggle = false,
+ ) => {
+ const policyOn = isPolicyOn(policy);
+ const metadata = parseJsonObject(jsonMetadata);
+ if ((!policyOn && !isPolicyToggle) || !metadata) {
+ return;
+ }
+ if (policy === undefined) {
+ delete metadata[POLICY_KEY];
+ } else {
+ metadata[POLICY_KEY] = policy;
+ }
+ if (policyOn) {
+ metadata.refresh_frequency = frequency;
Review Comment:
**Suggestion:** When the policy is off, Advanced JSON edits do not update
`refreshFrequency`; enabling the policy writes that stale select value here and
discards the edited default.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect variable
usage`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6aea22ab86254f478d333bb5c1e94c96&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6aea22ab86254f478d333bb5c1e94c96&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
**Line:** 679:679
**Comment:**
*Incorrect Variable Usage: When the policy is off, Advanced JSON edits
do not update `refreshFrequency`; enabling the policy writes that stale select
value here and discards the edited default.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F46037&comment_hash=5a833c00d63bd8277505e8f58263a0657030491c85dae477e13c6d842f8216e1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F46037&comment_hash=5a833c00d63bd8277505e8f58263a0657030491c85dae477e13c6d842f8216e1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
