PrakharAgarwal17 opened a new pull request, #46008:
URL: https://github.com/apache/superset/pull/46008

   ### SUMMARY
   
   Fixes: #45964 
   
   Fixes a regression where the Table chart (and the AG Grid Table) applied the 
selected **Time grain** to only the first temporal dimension. Any further 
temporal dimension was sent to the database as a raw column, so rows that 
differ only by day/time were not grouped, and the table showed several rows 
that all rendered as the same month with different counts.
   
   **Cause:** `buildQuery` used a single `temporalColumnAdded` flag, so only 
the first physical temporal column was converted to a time-grain adhoc column; 
later ones fell through unchanged. The backend form-data path 
(`_table_temporalized_columns`) had the same behavior.
   
   **Change:**
   - Table and AG Grid Table `buildQuery`: apply the grain to every selected 
physical temporal column. The first temporal column is still placed first in 
the query (unchanged behavior); other temporal columns keep their position; 
non-temporal and custom SQL columns are untouched.
   - Backend `_table_temporalized_columns` in `form_data_query_context.py`: 
same behavior, including the dashboard time grain override.
   - Added regression tests (see below).
   
   Note: charts with several temporal dimensions will now return correctly 
grouped rows, so numbers on existing saved charts can change (they were 
previously duplicated/ungrouped).
   
   ### BEFORE/AFTER SCREENSHOTS
   **Before:** 
   
   <img width="930" height="472" alt="image" 
src="https://github.com/user-attachments/assets/5d75d73d-b5a8-4f11-b0ca-d3d39e28dc83";
 />
   
   **After:** 
   
   <img width="1632" height="827" alt="image" 
src="https://github.com/user-attachments/assets/d9d18f6d-82cb-4d83-a9ca-4cf68bc3bb5c";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] fix(ta... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... rebenitez1802 (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... netlify[bot] (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... codecov[bot] (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications

Reply via email to