mikebridge opened a new pull request, #46013: URL: https://github.com/apache/superset/pull/46013
### SUMMARY TL;DR: The create-chart page points users to both datasource creation paths when Semantic Layers is enabled, and the Datasets list names both kinds in a mixed bulk selection. Before: Beside “Choose a datasource,” the only creation link said “Add a dataset” and opened dataset creation. Selecting a physical dataset and a semantic view together showed “2 Selected (Physical).” After: With Semantic Layers enabled, “Add a datasource” opens the Datasources list and a second link opens the semantic-view creation form directly. With the flag off, “Add a dataset” still opens dataset creation. A mixed selection shows “2 Selected (1 Physical, 1 Semantic View).” The documentation and translation template include the new wording. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; the text and links are covered by component tests. ### TESTING INSTRUCTIONS 1. Enable Semantic Layers and open Create Chart. Confirm “Add a datasource” opens the Datasources list and “create a semantic view” opens its creation form. 2. Disable Semantic Layers and confirm “Add a dataset” opens dataset creation and no semantic-view link appears. 3. On the Datasources list, select one physical dataset and one semantic view in bulk mode. Confirm the label names both kinds. 4. Automated checks: three focused Jest suites (116 tests), translation template drift check, and changed-file pre-commit hooks passed. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `SEMANTIC_LAYERS` for the expanded creation paths - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
