villebro commented on issue #8939: Add support for Dremio as a new source URL: https://github.com/apache/incubator-superset/pull/8939#issuecomment-572407877 Quick second pass: - you need to add ASF license headers to the new file. - you need to run `isort` (import order incorrect). - you need to run `black` (reformatting). - you need to implement `epoch_to_dttm()` in the the engine spec. You can check these errors in the CI log.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
