dpgaspar commented on a change in pull request #8941: [dashboards] New, export 
api
URL: 
https://github.com/apache/incubator-superset/pull/8941#discussion_r366195433
 
 

 ##########
 File path: superset/views/dashboard/views.py
 ##########
 @@ -44,8 +44,7 @@ class DashboardModelView(
     datamodel = SQLAInterface(models.Dashboard)
 
     @action("mulexport", __("Export"), __("Export dashboards?"), "fa-database")
-    @staticmethod
-    def mulexport(items):
+    def mulexport(self, items):  # pylint: disable=no-self-use
 
 Review comment:
   It's related with this already merged PR: 
https://github.com/apache/incubator-superset/pull/8942
   
   the `@action` decorator creates a methods attribute on the method, this is 
defeated by making the method static

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to