mistercrunch commented on a change in pull request #8845: [dashboard] New, list
view (react)
URL:
https://github.com/apache/incubator-superset/pull/8845#discussion_r366537111
##########
File path: superset/assets/src/welcome/DashboardTable.jsx
##########
@@ -18,34 +18,106 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
-import { Table, Tr, Td, unsafe } from 'reactable-arc';
-import { SupersetClient } from '@superset-ui/connection';
import { t } from '@superset-ui/translation';
+import { SupersetClient } from '@superset-ui/connection';
+import moment from 'moment';
+import { debounce } from 'lodash';
+import ListView from 'src/components/ListView/ListView';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
-import withToasts from '../messageToasts/enhancers/withToasts';
-import Loading from '../components/Loading';
-import '../../stylesheets/reactable-pagination.less';
-
-const propTypes = {
- search: PropTypes.string,
- addDangerToast: PropTypes.func.isRequired,
-};
+const PAGE_SIZE = 25;
class DashboardTable extends React.PureComponent {
- constructor(props) {
- super(props);
- this.state = {
- dashboards: null,
- };
+ static propTypes = {
+ addDangerToast: PropTypes.func.isRequired,
+ search: PropTypes.string,
+ };
+
+ state = {
Review comment:
Is this the same as setting `state` in the constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
