mistercrunch commented on a change in pull request #8960: fix: shut off
unneeded endpoints
URL:
https://github.com/apache/incubator-superset/pull/8960#discussion_r367243043
##########
File path: superset/views/log/views.py
##########
@@ -24,3 +24,4 @@
class LogModelView(LogMixin, SupersetModelView): # pylint:
disable=too-many-ancestors
datamodel = SQLAInterface(models.Log)
+ include_route_methods = {"list"}
Review comment:
I think what makes sense is either `{"list", "show"}` or nothing here. I was
thinking about leaving it for backwards compatibility. I could put it behind a
config flag too, let me do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
