mistercrunch commented on a change in pull request #8960: fix: shut off
unneeded endpoints
URL:
https://github.com/apache/incubator-superset/pull/8960#discussion_r369398242
##########
File path: superset/app.py
##########
@@ -324,23 +323,11 @@ def init_views(self) -> None:
category_label=__("Sources"),
category_icon="fa-wrench",
)
- appbuilder.add_link(
- "Tables",
- label=__("Tables"),
- href="/tablemodelview/list/?_flt_1_is_sqllab_view=y",
- icon="fa-table",
- category="Sources",
- category_label=__("Sources"),
- category_icon="fa-table",
- )
#
# Conditionally setup log views
#
- if (
- not self.config["FAB_ADD_SECURITY_VIEWS"] is False
- or self.config["SUPERSET_LOG_VIEW"] is False
- ):
+ if self.config["FAB_ADD_SECURITY_VIEWS"] and
self.config["SUPERSET_LOG_VIEW"]:
Review comment:
Oh right. Well then I'm fixing the logic. It's not super clear reading the
code that the `or` operator precedes `not`.
But I'm thinking that if either of these settings are moved away from their
default (of `True`), we should not show the log view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
