willbarrett commented on a change in pull request #8993: [log] fix, log model
view permissions
URL:
https://github.com/apache/incubator-superset/pull/8993#discussion_r369806645
##########
File path: tests/security_tests.py
##########
@@ -594,11 +594,16 @@ def test_is_admin_only(self):
)
)
- self.assertTrue(
- security_manager._is_admin_only(
- security_manager.find_permission_view_menu("can_delete",
"DatabaseView")
+ log_permissions = ["can_list", "can_show", "can_add", "can_edit",
"can_delete"]
Review comment:
By default, I think we don't want logs to be editable. I'd remove `can_add`,
`can_edit`, and `can_delete` for all users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
