john-bodley opened a new pull request #8995: [druid] Making scaning/refreshing 
Druid datasource view items optional
URL: https://github.com/apache/incubator-superset/pull/8995
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   Some deployments with charts backed by the legacy Druid NoSQL connector 
can't simply go cold turkey on fully disabling Druid however we would like to 
wean ourselves off starting by removing the option to scan for new or refresh 
the metadata of the Druid datasources. Note the later menu item is somewhat of 
a misnomer as it refreshes all Druid datasource from the source and not just 
those currently registered in Superset. 
   
   This PR adds a config option to simply remove the view items for 
scanning/refreshing Druid datasources.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE 
   
   When `DRUID_IS_ACTIVE = True` (non-default) and `DRUID_METADATA_VIEW_LINKS = 
True` (default)
   
   ![Screen Shot 2020-01-22 at 1 27 45 
PM](https://user-images.githubusercontent.com/4567245/72936451-1346b100-3d1c-11ea-9608-11c91cc76a85.png)
   
   #### AFTER 
   
   When `DRUID_IS_ACTIVE = True` (non-default) and `DRUID_METADATA_VIEW_LINKS = 
False` (non-default)
   
   ![Screen Shot 2020-01-22 at 1 27 25 
PM](https://user-images.githubusercontent.com/4567245/72936465-193c9200-3d1c-11ea-9aa6-08ef023146ed.png)
   
   ### TEST PLAN
   
   CI and tested locally. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @michellethomas @mistercrunch @willbarrett 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to