robdiciuccio opened a new pull request #9007: Serialize nested columns as JSON strings URL: https://github.com/apache/incubator-superset/pull/9007 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY SQL Lab queries against databases with nested columns/results containing structs or maps are failing with the following error: ``` pyarrow.lib.ArrowNotImplementedError: Not implemented type for list in DataFrameBlock: struct<...> ``` Serializing results to JSON is not the ideal solution, mainly for performance reasons, but there are pending fixes yet to be released in Arrow 1.0 that may improve the situation: https://github.com/apache/arrow/pull/6199 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Ensure queries against databases containing nested columns (particularly arrays containing maps) are successful. Per https://github.com/apache/incubator-superset/issues/8978, the following query should succeed and produce the proper results: ``` SELECT id, json_agg(json_build_object('table_name',table_name,'database_id',database_id)) FROM (SELECT * FROM tables) AS tables GROUP BY id ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: #8978 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @lxhoang97 @graceguo-supercat @john-bodley @michellethomas @villebro
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
