graceguo-supercat opened a new pull request #9009: [perf_logging] Add is_cached status when chart has error URL: https://github.com/apache/incubator-superset/pull/9009 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY when user load dashboard, if query returns 0 row, we will show `no data` and response 400. Superset front-end treat it as error. But the result will still be cached. In front-end logging, we don't log is_cached status when chart has error. this may cause our cache rate not accurate. This PR is trying to fix this case (chart has error, and may also has is_cached status). ### TEST PLAN manual test ### REVIEWERS @etr2460
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
