etr2460 commented on a change in pull request #9018: Add revert guidelines to CONTRIBUTING.md URL: https://github.com/apache/incubator-superset/pull/9018#discussion_r370898985
########## File path: CONTRIBUTING.md ########## @@ -226,6 +227,22 @@ If the PR passes CI tests and does not have any `need:` labels, it is ready for If an issue/PR has been inactive for >=30 days, it will be closed. If it does not have any status label, add `inactive`. +## Revert Guidelines + +Reverting changes that are causing issues in the master branch is a normal and expected part of the development process. In an open source community, the ramifications of a change cannot always be fully understood. With that in mind, here are some considerations to keep in mind when considering a revert: + +- **Availability of the PR author:** If the original PR author or the engineer who merged the code is highly available and can provide a fix in a reasonable timeframe, this would counter-indicate reverting. +- **Severity of the Issue:** How severe is the problem on master? Is it keeping the project from moving forward? Is there user impact? What percentage of users will experience a problem? +- **Size of the change being reverted:** Reverting a single small PR is a much lower-risk proposition than reverting a massive, multi-PR change. +- **Age of the change being reverted:** Reverting a recently-merged PR will be more acceptable than reverting an older PR. A bug discovered in an older PR is unlikely to be causing widespread serious issues. +- **Risk inherent in Reverting:** Will the reversion break critical functionality? Is the medicine more dangerous than the disease? Review comment: sp nit: uncapitalize `Reverting` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
