john-bodley commented on a change in pull request #9020: [Caching] Ensure cache is always created URL: https://github.com/apache/incubator-superset/pull/9020#discussion_r370917499
########## File path: superset/config.py ########## @@ -571,10 +572,6 @@ class CeleryConfig: # pylint: disable=too-few-public-methods SMTP_PASSWORD = "superset" SMTP_MAIL_FROM = "[email protected]" -if not CACHE_DEFAULT_TIMEOUT: Review comment: This logic is in the same block as line #313 and always evaluates to `True` and thus isn't required (hence the deletion). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
