dpgaspar opened a new pull request #9024: Propose cache type simple
URL: https://github.com/apache/incubator-superset/pull/9024
 
 
   ### CATEGORY
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Seems like #9019 makes startup fail on a default configuration. Tests pass 
because they set cache to simple. We can revert/fix #9019 or change cache 
default to simple (assuming it's limitations): 
https://flask-caching.readthedocs.io/en/latest/#simplecache
   
   Startup error:
   ```
   class PrestoEngineSpec(BaseEngineSpec):
     File 
"/home/dpgaspar/workarea/preset/preset_fork_superset/superset/db_engine_specs/presto.py",
 line 950, in PrestoEngineSpec
       @cache.memoize()
     File 
"/home/dpgaspar/workarea/preset/v_superset/lib/python3.6/site-packages/werkzeug/local.py",
 line 348, in __getattr__
       return getattr(self._get_current_object(), name)
   AttributeError: 'NoneType' object has no attribute 'memoize'
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to