etr2460 commented on a change in pull request #9025: [dashboard] fix, add config to optionally enable react replacement fo… URL: https://github.com/apache/incubator-superset/pull/9025#discussion_r371335155
########## File path: superset/views/dashboard/views.py ########## @@ -40,6 +40,8 @@ from ..utils import bootstrap_user_data from .mixin import DashboardMixin +config = app.config Review comment: is there a reason why we don't reference the app from inside the function instead of pulling the config out at global scope? I know i've seen this pattern a lot, but we've run into issues with tests because of it in the past. do you think it might be better to move it to the function? cc @john-bodley for his thoughts ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
