john-bodley opened a new pull request #9030: [fix] Reverting metic logic from #8901 URL: https://github.com/apache/incubator-superset/pull/9030 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR reverts the metric cleanup logic defined in https://github.com/apache/incubator-superset/pull/8901 as the superset-ui currently defines the metrics in the form `{"label": <name>}` per [here](https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-query/src/convertMetric.ts#L20). Given that the superset-ui build is currently broken (though is actively being worked on) it seems like reverting the so-called temporary logic probably makes the most sense for now. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @etr2460 @villebro cc: @williaster
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
