derari opened a new pull request #9043: Add support for Cockroach DB
URL: https://github.com/apache/incubator-superset/pull/9043
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Adds support for Cockroach DB.
   
   I could not test the change becaues the container always fails with
   ```
   superset_1         | standard_init_linux.go:211: exec user process caused 
"no such file or directory"
   ```
   but this seems unrelated to my change.
   
   So far I could use Cockroach DB in superset even without explicit support, 
only the time grain options were missing. 
   
   I verified that the time grain options declared by PostgresEngineSpec work 
with Cockroach DB.
   
   ### TEST PLAN
   Add a Cockroach DB datasource, add tables and test charts.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #9032
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to