etr2460 commented on a change in pull request #9041: [sqllab] Showing schema
length only when schema selected
URL:
https://github.com/apache/incubator-superset/pull/9041#discussion_r372478258
##########
File path: superset/assets/src/components/TableSelector.jsx
##########
@@ -370,10 +370,12 @@ export default class TableSelector extends
React.PureComponent {
<div className="section">
<ControlLabel>
{t('See table schema')}{' '}
- <small>
- ({this.state.tableOptions.length} {t('in')}{' '}
- <i>{this.props.schema}</i>)
- </small>
+ {this.props.schema && (
+ <small>
+ ({this.state.tableOptions.length} {t('in')}{' '}
Review comment:
i know you didn't add it, but this translation block really doesn't do
anything here, as translating chunks of sentences doesn't really work. you
could fix it if you wanted
```suggestion
{this.state.tableOptions.length} in{' '}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
