willbarrett commented on a change in pull request #9046: [query] deprecate
can_only_access_owned_queries
URL:
https://github.com/apache/incubator-superset/pull/9046#discussion_r372655710
##########
File path: superset/security/manager.py
##########
@@ -538,11 +536,10 @@ def create_custom_permissions(self) -> None:
"""
Create custom FAB permissions.
"""
-
self.add_permission_view_menu("all_datasource_access",
"all_datasource_access")
self.add_permission_view_menu("all_database_access",
"all_database_access")
self.add_permission_view_menu(
Review comment:
Why is creating the permission tied to the concept of a `view` and the
concept of a `menu`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
