etr2460 commented on a change in pull request #9051: [explore] Modal to edit
chart properties
URL:
https://github.com/apache/incubator-superset/pull/9051#discussion_r373577788
##########
File path: superset/assets/src/explore/components/DisplayQueryButton.jsx
##########
@@ -75,9 +77,12 @@ export default class DisplayQueryButton extends
React.PureComponent {
error: null,
filterText: '',
sqlSupported: datasource && datasource.split('__')[1] === 'table',
+ propertiesModalOpen: false,
Review comment:
small nit: i generally prefer to start boolean attributes with `is` or
`has`, so this would be `isPropertiesModalOpen`. i find it adds a bit of clarity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
