etr2460 commented on a change in pull request #8999: [charts] new, list view (react) URL: https://github.com/apache/incubator-superset/pull/8999#discussion_r373594777
########## File path: superset/assets/src/views/chartList/ChartList.tsx ########## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { SupersetClient } from '@superset-ui/connection'; +import { t } from '@superset-ui/translation'; +import moment from 'moment'; +import PropTypes from 'prop-types'; +import React from 'react'; +// @ts-ignore +import { Button, Modal, Panel } from 'react-bootstrap'; +import ConfirmStatusChange from 'src/components/ConfirmStatusChange'; +import ListView from 'src/components/ListView/ListView'; +import { FetchDataConfig, FilterTypeMap } from 'src/components/ListView/types'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +const PAGE_SIZE = 25; + +interface Props { + addDangerToast: (msg: string) => void; + addSuccessToast: (msg: string) => void; +} + +interface State { + chartCount: number; + charts: any[]; + filterTypes: FilterTypeMap; + labelColumns: { [key: string]: string }; + lastFetchDataConfig: FetchDataConfig | null; + loading: boolean; + permissions: string[]; +} + +interface Chart { + changed_on: string; + creator: string; + id: number; + slice_name: string; + url: string; + viz_type: string; +} + +class ChartList extends React.PureComponent<Props, State> { + + get canEdit() { + return this.hasPerm('can_edit'); + } + + get canDelete() { + return this.hasPerm('can_delete'); + } + + public static propTypes = { + addDangerToast: PropTypes.func.isRequired, + }; + + public state: State = { + chartCount: 0, + charts: [], + filterTypes: {}, + labelColumns: {}, + lastFetchDataConfig: null, + loading: false, + permissions: [], + }; + + public initialSort = [{ id: 'changed_on', desc: true }]; + + public columns = [ + { + Cell: ({ + row: { + original: { url, slice_name }, + }, + }: any) => <a href={url}>{slice_name}</a>, + Header: t('Chart'), + accessor: 'slice_name', + filterable: true, + sortable: true, + }, + { + Cell: ({ + row: { + original: { viz_type }, + }, + }: any) => viz_type, + Header: t('Visualization Type'), + accessor: 'viz_type', + sortable: true, + }, + { + Cell: ({ + row: { + original: { datasource_name_text, datasource_link }, + }, + }: any) => <a href={datasource_link}>{datasource_name_text}</a>, + Header: t('Datasource'), + accessor: 'datasource_name_text', + sortable: true, + }, + { + Cell: ({ + row: { + original: { changed_by_name, changed_by_url }, + }, + }: any) => <a href={changed_by_url}>{changed_by_name}</a>, + Header: t('Creator'), + accessor: 'creator', + sortable: true, + }, + { + Cell: ({ + row: { + original: { changed_on }, + }, + }: any) => ( + <span className='no-wrap'>{moment(changed_on).fromNow()}</span> + ), + Header: t('Last Modified'), + accessor: 'changed_on', + sortable: true, + }, + { + Cell: ({ row: { state, original } }: any) => { + const handleDelete = () => this.handleChartDelete(original); + const handleEdit = () => this.handleChartEdit(original); + if (!this.canEdit && !this.canDelete) { + return null; + } + + return ( + <span className={`actions ${state && state.hover ? '' : 'invisible'}`}> + {this.canDelete && ( + <ConfirmStatusChange + title={t('Please Confirm')} + description={<>{t('Are you sure you want to delete')} <b>{original.slice_name}</b>?</>} + onConfirm={handleDelete} + > + {(confirmDelete) => ( + <span + role='button' + className='action-button' + onClick={confirmDelete} + > + <i className='fa fa-trash' /> + </span> + )} + </ConfirmStatusChange> + )} + {this.canEdit && ( + <span + role='button' + className='action-button' + onClick={handleEdit} + > + <i className='fa fa-pencil' /> + </span> + )} + </span> + ); + }, + Header: 'Actions', + id: 'actions', + }, + ]; + + public hasPerm = (perm: string) => { + if (!this.state.permissions.length) { + return false; + } + + return Boolean(this.state.permissions.find((p) => p === perm)); + } + + public handleChartEdit = ({ id }: { id: number }) => { + window.location.assign(`/chart/edit/${id}`); + } + + public handleChartDelete = ({ id, slice_name }: Chart) => { + SupersetClient.delete({ + endpoint: `/api/v1/chart/${id}`, + }).then( + (resp) => { + const { lastFetchDataConfig } = this.state; + if (lastFetchDataConfig) { + this.fetchData(lastFetchDataConfig); + } + this.props.addSuccessToast(t('Deleted') + ` ${slice_name}`); + }, + (err: any) => { + this.props.addDangerToast(t('There was an issue deleting') + `${slice_name}`); Review comment: looks like this is missing a space before slice_name. Although I don't think this translation will actually work anyway. i believe there's a way to put `%s` or something in the translation string so that the full sentence gets parsed for translation. You could look in the code to find it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
