willbarrett commented on a change in pull request #9056: Do not show
stacktraces on some intentionally-thrown errors
URL:
https://github.com/apache/incubator-superset/pull/9056#discussion_r373720015
##########
File path: superset/views/core.py
##########
@@ -1363,7 +1363,9 @@ def testconn(self):
except Exception as e:
logging.exception(e)
return json_error_response(
- "Connection failed!\n\n" "The error message returned
was:\n{}".format(e)
+ "Connection failed!\n\n"
+ "The error message returned was:\n{}".format(e),
Review comment:
Thanks for the review Ville! I'm happy to use either approach. As I'm still
somewhat new to Python, it would be very useful for me to understand the
reasoning behind your suggestion. Would you mind expanding a little bit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
