etr2460 opened a new pull request #9064: [SQL Lab] Improve autocomplete performance URL: https://github.com/apache/incubator-superset/pull/9064 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Our instance of superset has large numbers of schemas and tables, so the sql lab autocomplete corpus can be around 40k elements long. Performing the object spread operator was taking up about 50% of the execution time, and removing was able to improve performance from 100ms per keystroke to 40ms. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After:  ### TEST PLAN Test autocomplete for all types of words, ensure it still works ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @graceguo-supercat @betodealmeida @michellethomas @john-bodley
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
