graceguo-supercat commented on a change in pull request #9070: [logging] Add
flag for document visibility
URL:
https://github.com/apache/incubator-superset/pull/9070#discussion_r374294770
##########
File path: superset/assets/src/middleware/loggerMiddleware.js
##########
@@ -107,6 +107,7 @@ const loggerMiddleware = store => next => action => {
...eventData,
event_type: 'user',
event_id: lastEventId,
+ visibility: document.visibilityState,
Review comment:
`timing event` (mostly is data loading and chart render) is triggered by
`user event` (dashboard mount, switch tab, etc). I assume during 1 user event
(a few charts will be loading and re-render), the browser's visibilityState
will not change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
