villebro commented on a change in pull request #9084: [Fix] Snowflake
connection bug of Apache Superset
URL:
https://github.com/apache/incubator-superset/pull/9084#discussion_r374776276
##########
File path: setup.py
##########
@@ -104,6 +104,7 @@ def get_git_sha():
"simplejson>=3.15.0",
"sqlalchemy>=1.3.5, <2.0",
"sqlalchemy-utils>=0.33.2",
+ "snowflake-sqlalchemy>=1.2.0",
Review comment:
Please fix the indentation here and move to `extras_require`;
`snowflake-sqlachemy` is not required to run Superset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
