john-bodley opened a new pull request #9093: [fix] Temporary filename for CSV upload to Hive URL: https://github.com/apache/incubator-superset/pull/9093 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR fixes a regression introduced in https://github.com/apache/incubator-superset/pull/9047 where the Hive CSV upload functionality wasn't updated to leverage temporary file logic. The `filename` is an absolute path (with the `config["UPLOAD_FOLDER"]` prefix and contains a secure file name) and thus there's no need to prefix it again. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Tested locally and confirmed the upload succeeded. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @dpgaspar @michellethomas @robdiciuccio
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
