etr2460 opened a new issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101 ## [SIP-36] Proposal for standardizing use of TypeScript ### Motivation Since [SIP-9](https://github.com/apache/incubator-superset/pull/6120) over a year ago, TypeScript has been a part of the Superset repo, but until now there has been no formal recommendation for using TypeScript throughout the Superset codebase. We've seen significant improvements in code quality and a decrease in bugs by requiring Python type hints, and therefore propose to enforce a similar requirement for TypeScript. By formally adopting TypeScript as the preferred frontend language within Superset, we expect to see a decrease in bugs and increase in developer productivity. ### Proposed Change CONTRIBUTING.md will be updated with the following requirements: - New frontend files should be written in TypeScript - When modifying old functions/components, migrating to TypeScript is appreciated, but not required - Additionally, examples of new functions/components in TypeScript and migration PRs will be provided alongside these requirements ### New or Changed Public Interfaces N/A ### New dependencies N/A, TypeScript is already integrated within Superset ### Migration Plan and Compatibility N/A ### Rejected Alternatives #### Flow Flow is an alternative typing system for Javascript, but it is only used by 35% of people (https://2019.stateofjs.com/javascript-flavors/other-tools/) compared to TypeScript with > 60% (https://2019.stateofjs.com/javascript-flavors/typescript/) #### No Typing We have rejected no JavaScript typing as an alternative because of the reasons mentioned above. to: @mistercrunch @rusackas @graceguo-supercat @nytai @kristw
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
