robdiciuccio commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r376674992
##########
File path: superset/sql_lab.py
##########
@@ -245,9 +245,6 @@ def execute_sql_statements(
db_engine_spec = database.db_engine_spec
db_engine_spec.patch()
- if store_results and not results_backend:
- raise SqlLabException("Results backend isn't configured.")
Review comment:
My understanding of `store_results` is that the query payload (including
results) should be persisted in the `RESULTS_BACKEND`. As it stands, this is
causing synchronous queries to try and persist this data, even if async queries
are disabled for a database, resulting in failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
