nytai opened a new pull request #9102: don't use msgpack if using SQLLAB_BACKEND_PERSISTENCE and returning r… URL: https://github.com/apache/incubator-superset/pull/9102 …esults ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> SQLLAB_BACKEND_PERSISTENCE feature stores the results in the results backend which is used to rehydrate tab states. Data is incorrectly being returned in serialized binary form due to the assumption that if we're storing results the query is being executed asynchronously. This pr fixes that assumption by also checking if we're looking to return results (in which case we don't want to serialize). ### TEST PLAN - [x] tested locally that sqllab works with SQLLAB_BACKEND_PERSISTENCE feature enabled - [x] tested locally that sqllab works with SQLLAB_BACKEND_PERSISTENCE feature disabled ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
