suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds
URL: 
https://github.com/apache/incubator-superset/pull/9114#issuecomment-584458879
 
 
   Whew. Had some trials and tribulations as you can see from the commit log 
but I dare say this is ready to go. Approvals/criticisms welcome.
   
   One change I was forced to make was moving `version_info.json` from 
`/static/assets` to `/static`. Issues arose around it being built by python 
code and also around webpack cleaning the contents of `/assets`. version_info 
isn't really an asset anyway, so I would argue that `/static` is the correct 
location for it in this directory structure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to