suddjian commented on a change in pull request #9120: Add feature flags to
control query sharing, KV exposure
URL:
https://github.com/apache/incubator-superset/pull/9120#discussion_r377910820
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.jsx
##########
@@ -45,9 +47,19 @@ class ShareSqlLabQuery extends React.Component {
shortUrl: t('Loading ...'),
};
this.getCopyUrl = this.getCopyUrl.bind(this);
+ this.getCopyUrlForSavedQuery = this.getCopyUrlForSavedQuery.bind(this);
+ this.getCopyUrlForKvStore = this.getCopyUrlForKvStore.bind(this);
Review comment:
`.bind(this)` is only necessary when you are going to be passing
`this.getCopyUrlForKvStore` around as a separate variable. If it's only called
via `this.getCopyUrlForKvStore` then `this` will be bound correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
