willbarrett commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379114268
########## File path: superset/datasets/commands/delete.py ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from flask_appbuilder.security.sqla.models import User + +from superset.commands.base import BaseCommand, CommandValidateReturn +from superset.datasets.commands.exceptions import ( + DatasetDeleteFailedError, + DatasetNotFoundError, +) +from superset.datasets.dao import DatasetDAO +from superset.views.base import check_ownership + + +class DeleteDatasetCommand(BaseCommand): + def __init__(self, user: User, model_id: int): + self._actor = user + self._model_id = model_id + self._model = None + + def run(self): + self._model = DatasetDAO.find_by_id(self._model_id) + if not self._model: + raise DatasetNotFoundError() + self.validate() + dataset = DatasetDAO.delete(self._model) + + if not dataset: + raise DatasetDeleteFailedError() + return dataset + + def validate(self) -> CommandValidateReturn: + is_valid, exceptions = super().validate() + check_ownership(self._model) Review comment: I assume this will raise on failure? Should we transform that error into an error message and return false? We're mixing paradigms for control flow here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
