villebro opened a new pull request #9149: fix: adhoc metric bug in chord diagram URL: https://github.com/apache/incubator-superset/pull/9149 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY The chord viz currently doesn't work with ad-hoc metrics due to the metric being replaced by the metric name. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After:  ### TEST PLAN Tested locally. Unit tests not added due to planned refactoring of `viz.py` in the near future. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: closes #8977 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @hefeng11725 @mtomov
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
